Add a test for utf8 function names #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0b
reviewed
May 4, 2017
| @@ -727,6 +727,23 @@ utf8_atoms(Config) when is_list(Config) -> | |||
| NoUtf8AtomForms = [{attribute,Anno,module,no_utf8_atom}|Forms], | |||
| error = compile:forms(NoUtf8AtomForms, [binary, r19]). | |||
|
|
|||
| utf8_functions(Config) when is_list(Config) -> | |||
| Anno = erl_anno:new(1), | |||
| Atom = binary_to_atom(<<"こんにちは"/utf8>>, utf8), | |||
There was a problem hiding this comment.
why not write this atom directly as 'こんにちは' ?
$ LANG=C.UTF-8 ./bin/erl +pc unicode
Erlang/OTP 20 [DEVELOPMENT] [erts-9.0] [source-95e22b1] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:10] [hipe] [kernel-poll:false]
Eshell V9.0 (abort with ^G)
1> 'こんにちは' =:= binary_to_atom(<<"こんにちは"/utf8>>, utf8).
trueThere was a problem hiding this comment.
@c0b This uses the same template as the test above and at the time the parser did not handle UTF-8 one. It is probably best to not be dependent on the parser on this case still.
bjorng
added
enhancement
team:VM
|
The test case |
The test found a bug in v3_kernel_pp which was not taking into account utf8 atoms. The bug has also been fixed.
josevalim
force-pushed
the
jv-atu8-function
branch
from
6eb8193
to
3393e22
Compare
|
@bjorng so it actually found a bug, just not the one I was expecting. :) The bug has been fixed and kernel_listing also passes now. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the coverage for UTF8 function names in compile_SUITE. Someone reported on the mailing list the feature no longer works. The test pass as of ffa80a4 but I still need to run it on latest master.
UPDATE: the test also passes on machine after rebuilding on current master.