Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info about support, compatibility, deprecation and removal #1839

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

rickard-green
Copy link
Contributor

No description provided.

@essen
Copy link
Contributor

essen commented Jun 14, 2018

👍

What about HiPE-compiled code? Is it the same compatibility guarantees?

@rickard-green
Copy link
Contributor Author

No, will add information about hipe code as well. Hipe is a bit special as well. We have recently updated the HiPE application with more information about this in 01b9a90

<item>
<p>
Erlang nodes can communicate across at least
two preceding and two subsequent releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear to the uninitiated reader whether 'releases' here includes 'maintenance package' or means 'major releases'. It would be worthwhile to be specific, since it has big implications on time durations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a section in the versions.xml file about this (part of this commit), which is linked from the misc.xml document, in order to clarify such questions.

<tag>Bug Fixes</tag>
<item>
<p>
We will not be bug compatible. A bug fix might introduce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug compatible -> bug-compatible ?

is preferred to be used instead of the old API that is being
deprecated. The deprecation does <em>not</em> imply removal
of the API unless an upcoming removal is explicitly stated
in the deprecation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it stated in the release notes, or in the compiler warning? Where should a developer keep a watch to know?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will include more info here

<title>Removal</title>
<p>
When it becomes necessary to remove legacy solutions they
are always phased out giving time for users to adopt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit weird to read. Maybe something like?

"Legacy solutions may eventually need to be removed. In such cases, they will be phased out on a long enough time period to give users the time to adapt."

of ERTS that was used when compiling the code. It might
however work on other builds, the emulator verifies
checksums in order to determine if it can load the code
or not. Note that HiPE have some limitations. For more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"have" should be "has"

<marker id="deprecation"/>
<title>Deprecation</title>
<p>
Functionality is deprecated when a new functionality is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deprecated when new functionality" (no "a")

@rickard-green rickard-green merged commit 6a82d68 into erlang:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants