Introduce a put_tuple2 instruction #1947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when building a tuple, there is no way to avoid an
extra
move
instruction. Consider this code:The corresponding BEAM code looks like this:
To avoid overwriting the source register
{x,0}
, amove
instruction is necessary.
The problem doesn't exist when building a list:
Introduce a new
put_tuple2
instruction that builds a tuple in asingle instruction, so that the
move
instruction can be eliminated:Note that the BEAM loader already combines
put_tuple
andput
instructions into an internal instruction similar to
put_tuple2
.Therefore the introduction of the new instruction will not speed up
execution of tuple building itself, but it will be less work for
the loader to load the new instruction.