Add checks if the file or dir names are sane. #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etc.
for <CR> and <LF> in them and return error if these offending chars
are found. See http://erlang.org/pipermail/erlang-bugs/2014-January/003998.html
for details.
lib/inets/test/ftp_suite_lib.erl: Added checks for <CR><LF> in file and directory
names.
|
Patch has passed first testings and has been assigned to be reviewed |
|
@sgolovan The commit title is a tad too long. Also, shouldn't the functions crash on illegal input? It looks weird to me to return |
|
Well, I didn't find any mention of crashing in ftp man page, so I tried not to introduce any. euser seems to be appropriate error condition since the FTP RFC doesn't allow \r\n in user names, so there can't be such a user. Though it's not too difficult to change all returns to throws (I'm just not sure what to throw out). |
|
Graduated |
uabboli
pushed a commit
to uabboli/otp
that referenced
this pull request
Dec 1, 2020
This commit fixes erlang#221 and updates the way the targeted implementation shrinks its instances. PropEr now tries to find the best shrinker between the original generator and the neighborhood function. Users can now also specify ?SHRINK macros in the neighborhood function, which will take precedence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/inets/src/ftp/ftp.erl: Check the filenames, usernames, passwords etc...
for and in them and return error if these offending chars
are found. See http://erlang.org/pipermail/erlang-bugs/2014-January/003998.html
for details.
lib/inets/test/ftp_suite_lib.erl: Added checks for in file and directory
names.