Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logger to use persistent_term for level checks #2356

Open
wants to merge 6 commits into
base: master
from

Conversation

@garazdawi
Copy link
Contributor

commented Aug 23, 2019

Move the primary and module-level checks into persistent_term.

I would also like to move the handler level checks (and possibly config) into persistent_term, but that is not done yet.

Also did some other small improvements/bug-fixes.

@bjorng

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Since this PR contains bug fixes, shouldn't it be targeted for maint?

@garazdawi garazdawi force-pushed the garazdawi:lukas/kernel/logger_fixes/OTP-15948 branch from 4793d0d to 5dcfbb1 Aug 29, 2019

@garazdawi

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

merged bug fix into maint, the rest will go into master

@tsloughter

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

I guess configs have to stay in ets because they need to be able to be updated without the persistent term penalty?

@garazdawi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

I've not decided what to do about them yet. I may move parts of the config from ets, or maybe all of it. Updates happen very rarely so maybe it would be ok to move it all.

@tsloughter

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Ah, ok. I'd argue for being in a persistent term and adding a note in the docs about what happens when updating the config. But maybe there are users who expect to be able to update that stuff constantly.

@garazdawi garazdawi force-pushed the garazdawi:lukas/kernel/logger_fixes/OTP-15948 branch from 5dcfbb1 to 2d84d86 Sep 6, 2019

@garazdawi

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

I've added the handler filter to be cached in persistent_term as well.

I think I'll leave the handler config out of persistent_term, as when we have decided that we should call the handler the overhead of the actual handler will overshadow the ets lookup needed to get the config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.