Fix unsafe optimization of receives #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhogberg
approved these changes
Oct 29, 2019
|
Should the |
bjorng
force-pushed
the
bjorn/compiler/fix-recv-opt/OTP-16219
branch
2 times, most recently
from
2ed53eb
to
61bd1d3
Compare
Fix a problem where a receive marker would be set even if it was not guaranteed that execution would reach a receive statement. See the new test case `receive_SUITE:return_before_receive/1` for an example where this would cause problems. https://bugs.erlang.org/browse/ERL-1076
bjorng
force-pushed
the
bjorn/compiler/fix-recv-opt/OTP-16219
branch
from
61bd1d3
to
784b339
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a problem where a receive marker would be set even if it
was not guaranteed that execution would reach a receive statement.
This optimization bug caused the problem for the
socketmodulereported here:
http://erlang.org/pipermail/erlang-questions/2019-October/098591.html
https://bugs.erlang.org/browse/ERL-1076