Skip to content

Properly lint calls in Core Erlang guards #257

Merged
merged 1 commit into from Mar 6, 2014

5 participants

@nox
nox commented Mar 1, 2014

Not all calls to the erlang module are legal guards in Core Erlang.

@nox
nox commented Mar 1, 2014

This is incomplete, as erlang:is_record/3 is not a true guard.

@OTP-Maintainer

Patch has passed first testings and has been assigned to be reviewed

@OTP-Maintainer

Patch has passed first testings and has been assigned to be reviewed

@bjorng
bjorng commented Mar 4, 2014

Thanks! Will test in our daily builds.

@nox
nox commented Mar 4, 2014

@bjorng I can handle erlang:is_record/3 as we don't plan to make it a true guard, right?

@bjorng
bjorng commented Mar 4, 2014

Yes, I forgot that. Please do. We have no plans to make it a true guard BIF.

@nox
nox commented Mar 4, 2014

Ok, will do that tonight.

@nox nox Properly lint calls in Core Erlang guards
Not all calls to the erlang module are legal guards in Core Erlang.
b381517
@nox
nox commented Mar 4, 2014

Amended.

@bjorng
bjorng commented Mar 5, 2014

I will test the amended branch in our daily builds.

@essen
essen commented Mar 5, 2014

Wow you sure wake up early. :-)

@psyeugenic psyeugenic merged commit b381517 into erlang:master Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.