Add types for new HiPE BIFs #265

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

kostis commented Mar 4, 2014

Commit 81c7db0
broke apart hipe_bif:make_fe/3 into two BIFs but forgot to properly update
the type information about HiPE BIFs in hipe_bif_types.erl. This commit fixes
this by taking out the types of hipe_bifs:make_fe/3 and adding types for the
new BIFs hipe_bifs:get_fe/2 and hipe_bifs:hipe_bifs_set_native_address_in_fe/2.

@kostis kostis Add types for new HiPE BIFs
Commit 81c7db0
broke apart hipe_bif:make_fe/3 into two BIFs but forgot to properly update
the type information about HiPE BIFs in hipe_bif_types.erl.  This commit fixes
this by taking out the types of hipe_bifs:make_fe/3 and adding types for the
new BIFs hipe_bifs:get_fe/2 and hipe_bifs:hipe_bifs_set_native_address_in_fe/2.
9e31660
Contributor

bjorng commented Mar 5, 2014

Thanks! I have amended the commit message to mention "erl_bif_types.erl" instead of "hipe_bif_types.erl" and included the branch in our daily builds.

Patch has passed first testings and has been assigned to be reviewed

Contributor

bjorng commented Mar 6, 2014

Merged.

bjorng closed this Mar 6, 2014

kostis deleted the kostis:hipe_bifs-types branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment