Skip to content

Add new make_fun3 instruction#2765

Closed
sverker wants to merge 0 commit into
erlang:masterfrom
sverker:sverker/make_fun3
Closed

Add new make_fun3 instruction#2765
sverker wants to merge 0 commit into
erlang:masterfrom
sverker:sverker/make_fun3

Conversation

@sverker

@sverker sverker commented Sep 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

*** MERGED *** MERGED *** MERGED ***
This PR is merged to master at 1073fa2

Compared to old make_fun2:

  • No GC done.
  • Environment and destination are arguments of instruction and not assumed x-registers.

Results in more effective register allocations.

@sverker sverker self-assigned this Sep 22, 2020
@sverker sverker added enhancement team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Sep 22, 2020
@bjorng

bjorng commented Sep 23, 2020

Copy link
Copy Markdown
Contributor

Looks good to me.

I have only one minor nit to pick: For Co-authored-by to work as intended, it must be placed last in the commit message.

bjorng
bjorng reviewed Oct 5, 2020
View reviewed changes
Comment thread lib/compiler/src/genop.tab
## a match context.
170: bs_start_match4/4

171: make_fun3/3

@bjorng bjorng Oct 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document make_fun/3.

@sverker sverker Oct 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bjorng

bjorng commented Oct 5, 2020

Copy link
Copy Markdown
Contributor

@sverker Two test cases fail in the compiler test suite on host ecthelion (to recreate locally, give the cover option when runnning the test suites).

You will need to include no_make_fun3 must be included in test_lib:opt_opts/1.

@garazdawi garazdawi added testing currently being tested, tag is used by OTP internal CI and removed testing currently being tested, tag is used by OTP internal CI labels Oct 6, 2020
@sverker sverker closed this Oct 7, 2020
@sverker sverker force-pushed the sverker/make_fun3 branch from e8138d2 to a43fa82 Compare October 7, 2020 10:40
@sverker

sverker commented Oct 7, 2020

Copy link
Copy Markdown
Contributor Author

*** MERGED *** MERGED *** MERGED ***
This PR is merged to master at 1073fa2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorng bjorng bjorng left review comments

Assignees

@sverker sverker

Labels

enhancement team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sverker @bjorng @garazdawi