Properly detect reused boolean values in beam_bool #279

Merged
merged 1 commit into from Mar 14, 2014

4 participants

@nox
nox commented Mar 8, 2014

The following code could crash the compiler:

f(X = true) when X or true or X -> ok.

@UlfNorell

@nox nox Properly detect reused boolean values in beam_bool
The following code could crash the compiler:

	f(X = true) when X or true or X -> ok.

Reported-by: Ulf Norell
3abbbee
@psyeugenic
Erlang/OTP member

Curious, if you work by day and fix compiler bugs by night .. when do you sleep? =)

@nox
nox commented Mar 8, 2014

Well… I don't begin work until 11am so... =)

@nox
nox commented Mar 8, 2014

Also, shouldn't you be sleeping yourself? :D

@psyeugenic
Erlang/OTP member

Reading up on white papers and watching Factory SF via Twitter .. but yeah =)

@nox
nox commented Mar 8, 2014

The real factory is on #erlounge :p

Guess I won't make any new PR tonight, the only remaining bug @UlfNorell reported not related to arbitrary map keys is the liveness analysis one, that one looks like a complete pain =)

@bjorng bjorng was assigned by psyeugenic Mar 11, 2014
@bjorng

Thanks! Included in our daily builds.

@proxyles proxyles merged commit 3abbbee into erlang:master Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment