Fix ssl ecc handshake crash on unknown curve #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TLS client sends a Supported Elliptic Curves Client Hello Extension containing an unknown curve enum value, a server crashes with a function_clause instead of just ignoring specified unknown curve.
When TLS client sends Supported Elliptic Curves Client Hello Extension server should select curves supported by both of them or refuse to negotiate the use of an ECC cipher suite. So it should be OK to ignore unknown curves specified by a client.
|
We have decided to include this but with a slightly different implementation. Thank you for your contribution! |
|
Are there chances for it to be included in R16B04? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original message at http://erlang.org/pipermail/erlang-questions/2014-March/078083.html
When buggy client or security scanner opens a connection to OTP ssl server and sends Supported Elliptic Curves Client Hello Extension with '0' or any other curve id not defined in tls_v1:enum_to_oid/1, a server crashes.
This pull requests fixes this problem by ignoring unknown curve ids.