Introduce os:getenv/2 #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
merged on master |
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 2, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
lemenkov
added a commit
to lemenkov/otp
that referenced
this pull request
Dec 15, 2014
See erlang#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
hguemar
pushed a commit
to rdo-common/erlang
that referenced
this pull request
Jul 13, 2017
See this GitHub pull request for further details: * erlang/otp#535 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see a lot of projects are using os:getenv/1 in a following way:
Var = case os:getenv("EnvName") of false -> "DefaultVal" ; EnvVal -> EnvVal end.
For example:
otp/lib/inets/test/erl_make_certs.erl
Line 219 in 983a39a
otp/lib/jinterface/test/jitu.erl
Line 120 in 983a39a
otp/lib/ssh/src/ssh_connection.erl
Line 1304 in 983a39a
...and many more. So let's introduce a new function for that!