JIT: Optimise common combinations of relational operators#6025
Merged
Conversation
bjorng
added
team:VM
Contributor
CT Test Results 4 files 367 suites 43m 49s ⏱️ Results for commit 439bdea. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
garazdawi
approved these changes
May 27, 2022
This is not an optimization in itself but it reduces the number of permutations of adjacent relational operators and thus will simplify instruction combination optimizations for the JIT.
The `cmp_arg()` helper would generate an unnecessary move to the
SUPER_TMP register if the RHS argument was an X register backed by a
CPU register. For example:
mov x14, x27
cmp x26, x14
This code can be simplified to:
cmp x26, x27
Optimize the generation of native code for common combinations of relational operators in guards.
bjorng
force-pushed
the
bjorn/jit/optimize-range-check
branch
from
May 30, 2022 02:13
439bdea to
f8a9ccd
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimise the generated code for common combinations of relational operators such as in the following examples: