Disconnect of a node from a cluster of global nodes #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickard-green
added
team:VM
CT Test Results 2 files 65 suites 58m 39s ⏱️ For more details on these failures, see this check. Results for commit 014bd58. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
rickard-green
force-pushed
the
rickard/global-disconnect/maint/OTP-18232
branch
2 times, most recently
from
1f76a4e
to
770318b
Compare
…d/global-disconnect/24.2/OTP-18232 * rickard/global-disconnect/23.3.4/OTP-18232: [kernel] Introduce global:disconnect/0
…global-disconnect/maint/OTP-18232 * rickard/global-disconnect/24.2/OTP-18232: [kernel] Introduce global:disconnect/0
rickard-green
force-pushed
the
rickard/global-disconnect/maint/OTP-18232
branch
from
770318b
to
014bd58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to disconnect a node from a cluster of
globalnodes without causing problems. Proposed API:global:disconnect() -> [node()]Disconnect from all other nodes known to
global. A list of node names (in an unspecified order) is returned which corresponds to the nodes that were disconnected. All disconnect operations performed have completed whenglobal:disconnect/0returns.The disconnects will be made in such a way that only the current node will be removed from the cluster of
globalnodes. Ifprevent_overlapping_partitionsis enabled and you disconnect, from other nodes in the cluster ofglobalnodes, by other means,globalon the other nodes may partition the remaining nodes in order to ensure that no overlapping partitions appear. Even ifprevent_overlapping_partitionsis disabled, you should preferably useglobal:disconnect/0in order to remove current node from a cluster ofglobalnodes, since you otherwise likely will create overlapping partitions which might cause problems.Note that if the node is going to be halted, there is no need to remove it from a cluster of
globalnodes explicitly by callingglobal:disconnect/0before halting it. The removal from the cluster is taken care of automatically when the node halts regardless of whetherprevent_overlapping_partitionsis enabled or not.If current node has been configured to be part of a global group, only connected and/or synchronized nodes in that group are known to
global, soglobal:disconnect/0will only disconnect from those nodes. If current node is not part of a global group, all connected visible nodes will be known toglobal, soglobal:disconnect/0will disconnect from all those nodes.Note that information about connected nodes does not instantaneously reach
global, so the caller might see a node part of the result returned bynodes()while it still is not known toglobal. The disconnect operation will, however, still not cause any overlapping partitions whenprevent_overlapping_partitionsis enabled. Ifprevent_overlapping_partitionsis disabled, overlapping partitions may form in this case.Note that when
prevent_overlapping_partitionsis enabled, you may see warning reports on other nodes when they detect that current node has disconnected. These are in this case completely harmless and can be ignored.