Map error logger warnings to warning messages by default #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
Nice catch. This one always perplexed me a bit when I first read about it. |
|
This is making some tests in error_logger_warn_SUITE fail, can you please make sure that they are all passing? |
Also fix and document the broken +We option.
richcarl
force-pushed
the
warnings-by-default
branch
from
565e6bd
to
441842c
Compare
|
I think I've modified the test cases correctly this time. At least the suite passes now. |
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
|
Merged to master with the following changes:
|
|
Hm, I don't see it in master yet. Just my commit merged a while back followed by a revert. |
|
Right, we don't always push master/maint to GitHub directly, only to our internal upstream. I'm sure we'll push it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix and document the broken +We option.