Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uptime() shell command #688

Merged
merged 1 commit into from May 20, 2015
Merged

Conversation

richcarl
Copy link
Contributor

@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@uabboli
Copy link
Contributor

uabboli commented May 7, 2015

Looks good. However, there is no spec, no test case (shell_SUITE or c_SUITE), and
no documentation in c(3).

Best regards,

Hans Bolinder, Erlang/OTP team, Ericsson

@richcarl
Copy link
Contributor Author

Added spec and xml docs, but none of the other info-printing shell functions have testcases, so I don't quite know how you'd like such a test to work. And the output is always different depending on the time when you run it, so you can only really test that the function prints a nonempty string.

@OTP-Maintainer
Copy link

Patch has passed first testings and has been assigned to be reviewed


I am a script, I am not human


@psyeugenic psyeugenic merged commit 6e24ffa into erlang:master May 20, 2015
@richcarl richcarl deleted the add-uptime-function branch May 20, 2015 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants