Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Take compiler options from beam in cover:compile_beam #74

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

gomoripeti commented Sep 10, 2013

Similarly to cover compiling from source
(in this case some user specified compiler options are allowed)
when cover compiling from existing beam
take a filtered list of compiler options from the beamfile.
This way e.g. export_all can be preserved. See use case in eb02beb

Contributor

gustehn commented Sep 11, 2013

Patch has passed first testings and has been assigned to be reviewed

Contributor

proxyles commented Oct 15, 2013

We would like you to add a testcase for this.
Other than that it is good to go.

Contributor

gomoripeti commented Oct 15, 2013

ok, I will add a testcase soon

Take compiler options from beam in cover:compile_beam
Similarly to cover compiling from source
(in this case some user specified compiler options are allowed)
when cover compiling from existing beam
take a filtered list of compiler options from the beamfile.
This way e.g. export_all can be preserved. See use case in eb02beb
Contributor

gomoripeti commented Oct 17, 2013

Hi, I amended the commit with a testcase (haven't rebased to current maint)

Contributor

gustehn commented Oct 24, 2013

Thanks,
The script is having some problems dealing with the "ö" in your branchname, trying to fix it right now. Sorry for spamming you. I'll close the pull request for now and deal with your branch manually.

@gustehn gustehn closed this Oct 24, 2013

Contributor

gustehn commented Nov 4, 2013

Merged,
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment