Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

add ability to dynamically make use of make -- minor #77

Closed
wants to merge 1 commit into from

4 participants

@expelledboy

No description provided.

@gustehn

Patch has passed first testings and has been assigned to be reviewed

@gustehn

Ok, I've got some feedback from the review for you:
The functionality is ok, but I think that the implementation should rather be an option to make:all/1 and make:files/2 instead of a new function i.e make:all([{emake,Emake}]). Where Emake is the same as the Emake arg to with/[1,2] in the patch. If present, Emake should be used instead of reading Emakefile from disk.
What do you think about that?

Also, it needs documentation and test, of course!

And I would like a better commit message which describes more exactly what the new functionality is.

@expelledboy

Okay thats easy enough to change code wise. I will have to look into how the docs are generated, and how your testcases are laid out. We dont really do either very well at the company I am working at :) so I have never had exposure to the otp way of doing things.

Might not be able to get to this this weekend.

@nox

@expelledboy The documentation is in lib/tools/doc/src/make.xml and tests are in lib/tools/test/make_SUITE.erl.

@garazdawi
Collaborator

closed due to inactivity, please re-open if you ever get around to completing this pr.

@garazdawi garazdawi closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Sep 15, 2013
  1. add ability to dynamically make use of make -- minor

    Anthony Jackson authored
This page is out of date. Refresh to see the latest.
Showing with 9 additions and 1 deletion.
  1. +9 −1 lib/tools/src/make.erl
View
10 lib/tools/src/make.erl
@@ -24,7 +24,7 @@
%% If Emakefile is missing the current directory is used.
-module(make).
--export([all/0,all/1,files/1,files/2]).
+-export([all/0,all/1,with/1,with/2,files/1,files/2]).
-include_lib("kernel/include/file.hrl").
@@ -42,6 +42,14 @@ all(Options) ->
error
end.
+with(Emake) ->
+ with(Emake, []).
+
+with(Emake,Options) ->
+ {MakeOpts,CompileOpts} = sort_options(Options,[],[]),
+ Files = transform(Emake,CompileOpts,[],[]),
+ do_make_files(Files,MakeOpts).
+
files(Fs) ->
files(Fs, []).
Something went wrong with that request. Please try again.