New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hex_core and add mirror_of repo config #1986

Merged
merged 2 commits into from Jan 1, 2019

Conversation

Projects
None yet
2 participants
@ericmj
Copy link
Contributor

ericmj commented Dec 29, 2018

No description provided.

Show resolved Hide resolved rebar.config Outdated

@ericmj ericmj force-pushed the ericmj:emj/mirror-of branch from 08738f6 to a85c4ca Dec 29, 2018

@ericmj

This comment has been minimized.

Copy link
Contributor Author

ericmj commented Dec 29, 2018

PR updated and hex_core updated hexpm/hex_core#51.

@ericmj ericmj force-pushed the ericmj:emj/mirror-of branch 5 times, most recently from a60acdd to c88f5d5 Dec 30, 2018

@ericmj ericmj force-pushed the ericmj:emj/mirror-of branch from c88f5d5 to 6a5ad07 Dec 30, 2018

@ericmj

This comment has been minimized.

Copy link
Contributor Author

ericmj commented Jan 1, 2019

This is ready for review.

Show resolved Hide resolved src/rebar_packages.erl Outdated
@ferd

ferd approved these changes Jan 1, 2019

@ericmj ericmj force-pushed the ericmj:emj/mirror-of branch from 79dd294 to 2884365 Jan 1, 2019

@ferd ferd merged commit edb8f3d into erlang:master Jan 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ericmj ericmj deleted the ericmj:emj/mirror-of branch Jan 1, 2019

@ferd

This comment has been minimized.

Copy link
Contributor

ferd commented Jan 3, 2019

@ericmj we got a regression from this patch where we used to display:
"===> Failed to update package from repo hexpm"
but apparently this no longer happens. I'm not too sure where in the code the flow was changed, but this is holding back cutting a release for now. I'll try to see what I can find.

_ = insert_releases(Name, Releases, Repo, ?PACKAGE_TABLE),
{ok, RegistryDir} = rebar_packages:registry_dir(State),
PackageIndex = filename:join(RegistryDir, ?INDEX_FILE),
ok = ets:tab2file(?PACKAGE_TABLE, PackageIndex);
{ok, {403, _Headers, <<>>}} ->
{ok, {403, _Headers, _}} ->

This comment has been minimized.

@ferd

ferd Jan 3, 2019

Contributor

This is the change that now eats up the warning on line 249/252

Seems the warning was accidentally in place. Maybe we should duplicate it up here.

This comment has been minimized.

@ericmj

ericmj Jan 3, 2019

Author Contributor

I made this change because it's not meaningful to match on an empty body on 403 responses, in fact repo.hex.pm never returns an empty body for 403. Maybe the clause should be removed instead?

This comment has been minimized.

@ferd

ferd Jan 3, 2019

Contributor

Yeah that would be fine

This comment has been minimized.

@ericmj

ericmj Jan 4, 2019

Author Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment