Escape more characters for shell stuff #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by Alexey Pronin, this would let people potentially pass in URLs that can call to command execution. While running arbitrary code is kind of our bread and butter, it makes sense to at least play nicely and escape more characters: - the pipe (`|`) which can be used to run subcommands - the tab (`\t`) which the shell interprets as a space. - the home directory (`~`) just because the expansion could behave funny - redirection (`<` and `>`) to avoid problems with data setting up streams
tsloughter
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by Alexey Pronin, this would let people potentially pass in
URLs that can call to command execution.
While running arbitrary code is kind of our bread and butter, it makes
sense to at least play nicely and escape more characters:
|) which can be used to run subcommands\t) which the shell interprets as a space.~) just because the expansion could behave funny<and>) to avoid problems with data setting upstreams