fix logger reset for the shell plugin #2428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The shell plugin has to reset the logger by fetching its configuration and
re-applying it later. In the current state,
maybe_reset_logger/1
will onlyre-apply part of the configuration (the
config
key), which does not includeother settings such as filters and formatters.
The effect can be demonstrated by adding filters or formatters to
~/.erlang
and running rebar3 shell on any project (without any --config argument, this
one reload the logger env; updating the kernel/logger environment in
~/.erlang
fixes it).For example:
This patch makes sure the default handler is re-created with its entire
original configuration.