Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_mode false issue with sys.config.orig #604

Closed
tsloughter opened this Issue Aug 14, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@tsloughter
Copy link
Member

tsloughter commented Aug 14, 2017

Opening this so I don't forget but still need to dig in to the problem to investigate.

Basically I noticed that changes to my config/sys_prod.config were not being included when I ran the release after a rebar3 as prod release. I then checked and found that the sys.config under the prod profile was correct after the rebar3 as prod release but then overwritten when the release is run and sys.config.orig is copied over sys.config.

So it seems something needs to be done when a release is rebuilt to remove sys.config.org?

@ferd

This comment has been minimized.

Copy link
Contributor

ferd commented Aug 14, 2017

Could alternatively prime both sys.config and sys.config.orig at once I guess?

@tsloughter

This comment has been minimized.

Copy link
Member Author

tsloughter commented Apr 5, 2018

I think we'll just want to ignore this issue as it won't be a problem come OTP21 and its support for sys.config.src.

@tsloughter tsloughter added the wontfix label Apr 5, 2018

@tsloughter

This comment has been minimized.

Copy link
Member Author

tsloughter commented Apr 5, 2018

Marking wontfix and will wait to close until I know the OTP21 way of doing things is working.

@tsloughter

This comment has been minimized.

Copy link
Member Author

tsloughter commented Jun 20, 2018

Closing since the latest relx supports sys_config_src.

@tsloughter tsloughter closed this Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.