Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang 17+ doesn't start by 'R' #195

Merged
merged 1 commit into from Jun 20, 2014
Merged

Conversation

edescourtis
Copy link

Fixed trivial issue with Makefile

@edescourtis
Copy link
Author

Travis CI fails for unrelated reasons it seems.

@jwilberding
Copy link
Member

@tsloughter Is this build failure related to your recent stuff?

@tsloughter
Copy link
Member

I guess... I'll get it fixed today. But disturbing is, why didn't travis catch it when it was a PR??

@jwilberding
Copy link
Member

Yeah, it isn't making any sense to me..

On Wed, Jun 18, 2014 at 4:36 PM, Tristan Sloughter <notifications@github.com

wrote:

I guess... I'll get it fixed today. But disturbing is, why didn't travis
catch it when it was a PR??


Reply to this email directly or view it on GitHub
#195 (comment).

@nuex
Copy link
Contributor

nuex commented Jun 19, 2014

I did a fresh relx install and this fixes my master build issues as well.

@tsloughter
Copy link
Member

Oh, duh, it wasn't caught because this fix is what causes it to properly run dialyzer for 17.x versions :)

The error it gives at first glance doesn't make sense though, Constraint can be string() so is_list/1 should be fine... But I'll figure it out.

@tsloughter
Copy link
Member

Got a fix. Merging this in now bc technically master is broken currently. Then opening up a PR with the dialyzer fixes.

tsloughter added a commit that referenced this pull request Jun 20, 2014
Erlang 17+ doesn't start by 'R'
@tsloughter tsloughter merged commit cccd90a into erlware:master Jun 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants