Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly render redefined variable #747

Merged
merged 1 commit into from Aug 13, 2019

Conversation

arcusfelis
Copy link
Contributor

Rendering of variables behaves differently for already defined
variables.
Values of such variables are rendered in the wrong order,
ignoring any variables above from the same file.

Failing test without the fix:

./rebar3/rebar3 ct --suite rlx_release_SUITE --case overlay_release   
===> Verifying dependencies...                                                                     
===> Compiling relx                                                                   
===> Running Common Test suites...                                                                     
%%% rlx_release_SUITE:                                                                                                                                                                                    
%%% rlx_release_SUITE ==> overlay_release: FAILED                                                  
%%% rlx_release_SUITE ==>                                                                                                                                                                                 
Failure/Error: ?assertEqual([82,101,100,101,102,105,110,101,100,32,105,110,32,118,97,114,115,50,32,119,105,116,104,32,97,32,116,101,109,112,108,97,116,101,32,118,97,108,117,101], proplists : get_value (
 tpl_var , TemplateData ))                                                                               
  expected: "Redefined in vars2 with a template value"                                                                                                                                                    
       got: "Redefined in vars2 with "                                                                              
      line: 866 

Rendering of variables behaves differently for already defined
variables.
Values of such variables are rendered in the wrong order,
ignoring any variables above from the same file.
@tsloughter tsloughter merged commit def78e1 into erlware:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants