Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace direct use of erl_syntax in favour of merl. #123

Closed
kaos opened this issue Feb 4, 2014 · 6 comments
Closed

Replace direct use of erl_syntax in favour of merl. #123

kaos opened this issue Feb 4, 2014 · 6 comments
Assignees
@kaos
Labels
compiler
Milestone
0.9.1

Comments

@kaos
Copy link
Member

kaos commented Feb 4, 2014

See https://github.com/richcarl/merl.
@ghost ghost assigned kaos Feb 4, 2014
@kaos kaos mentioned this issue Feb 4, 2014
Open
@kaos
Copy link
Member Author

kaos commented Feb 17, 2014

This will also address the issue noticed in #124 (comment).
EDIT: not directly. It will make it easier to address.

@kaos kaos added this to the 0.9.1 milestone Feb 17, 2014
kaos added a commit that referenced this issue Feb 18, 2014
@kaos
Converting erl_syntax calls to merl ?Q quote ones (#123).
7358c0a
kaos added a commit that referenced this issue Feb 21, 2014
@kaos
more conversions (#123)
0f95dff
kaos added a commit that referenced this issue Feb 21, 2014
@kaos
... and more conversions (#123)
577a665
kaos added a commit that referenced this issue Feb 22, 2014
@kaos
Use merl [1] for compiling the erlang AST tree (fixes #123).
f31477a 
Also, `number_literals` are now converted to erlang integers in the scanner.

[1] https://github.com/richcarl/merl
@kaos kaos added the fixed label Feb 22, 2014
kaos added a commit that referenced this issue Feb 22, 2014
@kaos
Use merl [1] for compiling the erlang AST tree (fixes #123).
a1c9198 
Also, `number_literals` are now converted to erlang integers in the scanner.

[1] https://github.com/richcarl/merl
@wardbekker
Copy link

Not sure if related, but using erlydtl as a dependency with rebar, and get the following error:

/home/foo/agigo.com/deps/erlydtl/src/erlydtl_compiler.erl:none: undefined parse transform 'merl_transform'

@kaos
Copy link
Member Author

kaos commented Feb 24, 2014

Yeah, I was expecting that.. thanks for reporting (and letting me know someone actually tried this out already ;)

The issue is that merl beam files are placed in erlydtl/deps/merl/ebin.. you need that on your code path. I've been thinking how to best solve this, no solution yet.

@kaos kaos removed the fixed label Feb 24, 2014
@kaos kaos mentioned this issue Feb 26, 2014
Closed
kaos added a commit that referenced this issue Feb 26, 2014
@kaos
Make sure merl gets built when using rebar (#123)
0e5635c
@kaos
Copy link
Member Author

kaos commented Feb 26, 2014

@wardbekker @nuex: could you please retry and see if it works better for you now, with the 0e5635c commit?

@nuex
Copy link
Contributor

nuex commented Feb 26, 2014

@kaos appears to work. No compilation errors. Thanks!

@kaos
Copy link
Member Author

kaos commented Feb 26, 2014

Excellent! :D

@kaos kaos added the fixed label Feb 26, 2014
@kaos kaos closed this as completed Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaos kaos

Labels
compiler
Projects
None yet
Milestone
0.9.1
Development

No branches or pull requests
3 participants
@nuex @wardbekker @kaos