compile_dir and escape w/undefined vars #124

Closed
gar1t opened this Issue Feb 4, 2014 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

gar1t commented Feb 4, 2014

When using erlydtl:compile_dir to create a module with render functions per template, the output generated for undefined escaped values is the atom 'undefined' rather than the binary <<"undefined">>.

Please refer to this git repo for details:

https://github.com/gar1t/erlydtl-escape-bug

kaos self-assigned this Feb 4, 2014

Owner

kaos commented Feb 4, 2014

Looking into this, I also noticed that the template compiled with compile_dir doesn't return a {ok, Result}, and doesn't return error either (any exceptions are not caught, which is inconsistent, really).

kaos added the fixed label Feb 6, 2014

kaos added this to the 0.9.0 milestone Feb 17, 2014

kaos closed this in dd186c6 Feb 17, 2014

@kaos kaos added a commit that referenced this issue Feb 24, 2014

@kaos kaos Fix result value of compile_dir templates
Relates to comment in #124.

This is a backwards breaking change (again, sorry, but it just wasn't
right as it was).

The compiled dir template now returns `{ok, Rendered}` or `{error,
Reason}` just as normally compiled templates.
0b61b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment