Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

compile_dir and escape w/undefined vars #124

Closed
gar1t opened this Issue · 1 comment

2 participants

@gar1t

When using erlydtl:compile_dir to create a module with render functions per template, the output generated for undefined escaped values is the atom 'undefined' rather than the binary <<"undefined">>.

Please refer to this git repo for details:

https://github.com/gar1t/erlydtl-escape-bug

@kaos kaos self-assigned this
@kaos
Owner

Looking into this, I also noticed that the template compiled with compile_dir doesn't return a {ok, Result}, and doesn't return error either (any exceptions are not caught, which is inconsistent, really).

@kaos kaos added the fixed label
@kaos kaos added this to the 0.9.0 milestone
@kaos kaos closed this in dd186c6
@kaos kaos referenced this issue from a commit
@kaos kaos Fix result value of compile_dir templates
Relates to comment in #124.

This is a backwards breaking change (again, sorry, but it just wasn't
right as it was).

The compiled dir template now returns `{ok, Rendered}` or `{error,
Reason}` just as normally compiled templates.
0b61b69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.