Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

out_dir compile warnings #128

Closed
gar1t opened this Issue · 2 comments

2 participants

@gar1t

It's surprising to me that a missing option constitutes a warning. What is the implication of not creating a beam file? I was under the impression that recompile checks were made against source file modified times using the compile module source file attribute.

I'd be happy to update the README with an explanation of why out_dir is useful/important, enough to generate a printed warning on compile.

@kaos
Owner

This is a good question that may benefit from being re-evaluated.

Although, whether the warning is printed or not depends on the report_warnings option flag.

I don't feel like getting rid of the warning implicitly, but I think we could introduce a new value for out_dir to explicitly say we don't want the beam file saved (thus avoiding the warning), by passing a {out_dir, false} when compiling.

@kaos kaos self-assigned this
@kaos kaos added this to the 0.9.0 milestone
@kaos
Owner

Your impression regarding the recompile checks are correct. The implication of not saving the beam code to file, as far as I can see, is that the compiled template will not survive a Erlang restart.

Feel free to add a note about this in the readme! :)

@kaos kaos added the fixed label
@kaos kaos closed this in ca93672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.