Changes to the add filter #38

Merged
merged 3 commits into from Aug 14, 2012

2 participants

@srstrong

The previous add filter only supported numbers, whereas the django spec indicates that the values will be coerced to numbers, and if that fails added anyway (i.e., string/list concatenation). The change is slightly messy, but I believe is at least closer to the spec.

@evanmiller

Hmm, OK. This behavior is poor API design but that is the fault of the Django spec. Please add unit tests (tests/src/erlydtl_unittests.erl) and I will merge this in.

@srstrong

Agreed on the API design! I've added in unit tests for the various combinations, let me know if there's anything else you need. Great library, BTW :)

@evanmiller evanmiller merged commit 8797a29 into erlydtl:master Aug 14, 2012
@evanmiller

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment