New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement notifications for queries and highlights #138

Merged
merged 1 commit into from Sep 13, 2014

Conversation

Projects
None yet
3 participants
@yuvipanda
Copy link
Contributor

yuvipanda commented Sep 13, 2014

  • Asks for permission when opening the app if it isn't already
    granted
  • Highlights with a notification that stays for 2s
  • Clicking on the notification brings that window/channel
    to focus
  • Uses document.hasFocus() rather than document.hidden, since
    it seems to be more accurate when the tab is in focus
    but the window is not

Imlements issue #128

Implement notifications for queries and highlights
- Asks for permission when opening the app if it isn't already
  granted
- Highlights with a notification that stays for 2s
- Clicking on the notification brings that window/channel
  to focus
- Uses document.hasFocus() rather than document.hidden, since
  it seems to be more accurate when the tab is in focus
  but the window is not

Imlements issue #128
@cjb

This comment has been minimized.

Copy link

cjb commented Sep 13, 2014

@yuvipanda Nice, thanks for doing this!

erming added a commit that referenced this pull request Sep 13, 2014

Merge pull request #138 from yuvipanda/notifications
Implement notifications for queries and highlights

@erming erming merged commit 80917ac into erming:master Sep 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment