Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.my.tojson exhaust stack in rear cases #25

Closed
ermouth opened this issue Apr 29, 2016 · 2 comments
Closed

$.my.tojson exhaust stack in rear cases #25

ermouth opened this issue Apr 29, 2016 · 2 comments
Labels
bug

Comments

@ermouth
Copy link
Owner

@ermouth ermouth commented Apr 29, 2016

Regexps in this fn https://github.com/ermouth/jQuery.my/blob/master/Release/1.2/jquerymy-1.2.4.js#L727 may produce enormously deep recursion and exhaust js machine stack.

Minor bug, this function is never used during normal runtime.

@ermouth ermouth added the bug label Apr 29, 2016
@ermouth
Copy link
Owner Author

@ermouth ermouth commented Apr 29, 2016

Takes place in Chrome cause V8 reflector behaves in a strange way, and this behavior seems to vary from version to version:

(new Function('a','return a')).toString() -->
"function anonymous(a
/**/) {
return a
}"

but

(function(a){return a}).toString() -->
"function (a){return a}"
ermouth added a commit that referenced this issue May 12, 2016
Fix for #24, #25
@ermouth
Copy link
Owner Author

@ermouth ermouth commented May 12, 2016

Fixed in 1.2.5

@ermouth ermouth closed this May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.