New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERRAI-1080] Add @ClassName annotation support. #305

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@treblereel
Contributor

treblereel commented Nov 15, 2017

@kie-ci

This comment has been minimized.

Collaborator

kie-ci commented Nov 15, 2017

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@mbarkley

This comment has been minimized.

Contributor

mbarkley commented Nov 15, 2017

ok to test

@mbarkley mbarkley self-requested a review Nov 15, 2017

@mbarkley

mbarkley suggested changes Nov 15, 2017 edited

Really great feature idea! As discussed on IRC, I think it would be greatly improved by supporting multiple class names, like this for example:

@ClassNames({"class1", "class2"})
@mbarkley

This comment has been minimized.

Contributor

mbarkley commented Nov 16, 2017

The build passed on Jenkins, it was just unable to update here for some reason. Going to merge.

@mbarkley mbarkley merged commit f98aada into errai:master Nov 16, 2017

1 check was pending

Linux Build triggered. sha1 is merged.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment