Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spell checking ... ? #38

Closed
jdkato opened this issue Apr 13, 2017 · 2 comments
Closed

Spell checking ... ? #38

jdkato opened this issue Apr 13, 2017 · 2 comments

Comments

@jdkato
Copy link
Member

jdkato commented Apr 13, 2017

My initial feelings on this were that it was out of scope: Vale is designed to work with the more subjective, stylistic parts of writing—not spelling and grammar.

However, I think its "syntax awareness" could prove useful here too. For example, checking source code comments and ignoring markup syntax and code blocks.
jdkato added a commit that referenced this issue Apr 17, 2017
@jdkato
feat: add Spelling check
8e3a0b0 
Closes #38
@jdkato
Copy link
Member Author

jdkato commented Apr 18, 2017

Closed by 083757e.

This is experimental for now. It seems to work quite well (and fast), but it did increase the binary size from ~4.1MB to ~11MB.

@jdkato jdkato closed this as completed Apr 18, 2017
@jdkato
Copy link
Member Author

jdkato commented May 8, 2017 •
edited
Loading

This was removed in v0.6.1. It might be added back, but I think the implementation should support a common dictionary format (e.g., Hunspell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jdkato