New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack channels #1145

Merged
merged 7 commits into from Jan 4, 2017

Conversation

Projects
None yet
3 participants
@gizotti
Copy link
Contributor

gizotti commented Dec 9, 2016

This is a follow up PR to #1095.

This adds the ability to users to select a channel in which the Slack notifications will be send when setting up Slack notifications.
The channel field is not compulsory and, if empty, the default channel setup on slack when creating the webhook.

TODO
  • Write specs to ensure the right payload is sent with a channel both selected or not
  • Validate room_id field to ensure it matches a slack channels name format
@gizotti

This comment has been minimized.

Copy link
Contributor Author

gizotti commented Dec 9, 2016

@stevecrozz #1095 can be closed 😄

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.06%) to 93.077% when pulling bb3314c on gizotti:slack-channel into bf81312 on errbit:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.06%) to 93.077% when pulling dafe037 on gizotti:slack-channel into bf81312 on errbit:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.06%) to 93.077% when pulling 59995e0 on gizotti:slack-channel into bf81312 on errbit:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.06%) to 93.077% when pulling 59995e0 on gizotti:slack-channel into bf81312 on errbit:master.

@gizotti gizotti changed the title [WIP] Slack channels Slack channels Dec 9, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.1%) to 93.148% when pulling b5b1ac6 on gizotti:slack-channel into bf81312 on errbit:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 9, 2016

Coverage Status

Coverage increased (+0.1%) to 93.148% when pulling 48c15d0 on gizotti:slack-channel into bf81312 on errbit:master.

@stevecrozz stevecrozz referenced this pull request Dec 23, 2016

Closed

Slack rooms #1095

@@ -16,6 +16,7 @@
%div.notification_params{:class => (w.object.is_a?(notification_service) ? 'chosen ' : '') << notification_service.label}
- notification_service::FIELDS.each do |field, field_info|
= w.label field, field_info[:label] || field.to_s.titleize
%em= field_info[:hint]

This comment has been minimized.

@stevecrozz

stevecrozz Dec 29, 2016

Member

Shouldn't this only be emitted if there is a hint?

This comment has been minimized.

@gizotti

gizotti Jan 3, 2017

Author Contributor

I guess an if statement here wouldn't hurt. That said, if the hint is blank the em will have 0 height.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 3, 2017

Coverage Status

Coverage increased (+0.2%) to 93.208% when pulling 23bf103 on gizotti:slack-channel into bf81312 on errbit:master.

@stevecrozz

This comment has been minimized.

Copy link
Member

stevecrozz commented Jan 3, 2017

Thanks @gizotti. This looks good. Will merge soon.

@gizotti

This comment has been minimized.

Copy link
Contributor Author

gizotti commented Jan 4, 2017

@stevecrozz no worries mate :) Happy to help

@stevecrozz stevecrozz merged commit 4fef608 into errbit:master Jan 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gizotti gizotti deleted the gizotti:slack-channel branch Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment