Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp config: support additional ssl related keys #1149

Merged
merged 2 commits into from Dec 19, 2016

Conversation

mattscilipoti
Copy link
Contributor

  • smtp_enable_starttls_auto, smtp_openssl_verify_mode

I did not see a way to have a default value for these settings. I would like to ensure that "enable_starttls_auto" as the expected default value of true.

See: http://api.rubyonrails.org/classes/ActionMailer/Base.html#class-ActionMailer::Base-label-Configuration+options

- smtp_enable_starttls_auto, smtp_openssl_verify_mode
@stevecrozz
Copy link
Member

Good idea @mattscilipoti. Would you also add docs for the new inputs to https://github.com/errbit/errbit/blob/master/docs/configuration.md ?

- SMTP_ENABLE_STARTTLS_AUTO, SMTP_OPENSSL_VERIFY_MODE
@coveralls
Copy link

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 93.077% when pulling db6713c on mattscilipoti:smtp_ssl into 8c01f94 on errbit:master.

@coveralls
Copy link

coveralls commented Dec 19, 2016

Coverage Status

Coverage remained the same at 93.077% when pulling 0d4b9ed on mattscilipoti:smtp_ssl into 8c01f94 on errbit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.077% when pulling 0d4b9ed on mattscilipoti:smtp_ssl into 8c01f94 on errbit:master.

@mattscilipoti
Copy link
Contributor Author

Docs were being added as you were asking for it. :)
Any ideas for the default values?

@stevecrozz
Copy link
Member

I think we oughtta leave the defaults unset because ActiveSupport has its own defaults for these config options. Are you ready for me to merge it?

@mattscilipoti
Copy link
Contributor Author

Yes. Ready to merge.

@stevecrozz stevecrozz merged commit 2d4ccc5 into errbit:master Dec 19, 2016
@stevecrozz
Copy link
Member

Thanks @mattscilipoti !

@mattscilipoti mattscilipoti deleted the smtp_ssl branch December 19, 2016 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants