Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test dependencies in the bundle install. #1390

Merged
merged 1 commit into from Nov 21, 2018

Conversation

connyay
Copy link
Contributor

@connyay connyay commented Nov 16, 2018

Before this change the postdeploy script was failing due to the :test
dependencies not being installed during the app deployment.

The default value for $BUNDLE_WITHOUT is development:test.

Fixes #1362.

Before this change the postdeploy script was failing due to the :test
dependencies not being installed during the app deployment.

The default value for `$BUNDLE_WITHOUT` is `development:test`.

Fixes errbit#1362.
@rud
Copy link
Contributor

rud commented Nov 21, 2018

Good point. Going forward we probably should stop installing test dependencies in production, but being able to generate demo-data is convenient.

@rud rud merged commit 380fefc into errbit:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants