update octokit, use api v3 #170

Merged
merged 1 commit into from Jun 1, 2012

Projects

None yet

2 participants

@nashby
Member
nashby commented Mar 23, 2012

closes #149

@ndbroadbent ndbroadbent commented on the diff Mar 23, 2012
@@ -13,7 +13,7 @@ gem 'mongoid_rails_migrations'
gem 'useragent', '~> 0.3.1'
gem 'pivotal-tracker'
gem 'ruby-fogbugz', :require => 'fogbugz'
-gem 'octokit', '0.6.4'
+gem 'octokit'
@ndbroadbent
ndbroadbent Mar 23, 2012 Member

Could we add , '~> x.x.x' here? To make sure the new gem is installed?

@nashby
nashby Mar 23, 2012 Member

Yeah, sure thing but are you sure we need this? As we have Gemfile.lock in repository I think it's not necessary.

@ndbroadbent
ndbroadbent Mar 23, 2012 Member

Ah, that's true, Octokit 1.0.0 will be installed when you next run bundle install.
But I still think it's a best practice to guard against unintentional updates (e.g. when 1.1.0 is released.)
Never mind though, I'll do that when I test it out.

Cheers

@nashby
nashby Mar 23, 2012 Member

I've updated :)

@ndbroadbent
Member

This looks great, thanks very much for doing that. Have you tested this in production? If not, I can do that before merging.

@nashby
Member
nashby commented Mar 23, 2012

Actually I didn't, sorry. It would be awesome if you do it :)

@nashby
Member
nashby commented May 13, 2012

@ndbroadbent any news on this issue?
I'm asking because we have github authentication feature based on this PR. It would be awesome to have it in upstream. You can check it here https://github.com/twinslash/errbit/tree/github :)

@ndbroadbent ndbroadbent merged commit 4ccc844 into errbit:master Jun 1, 2012
@ndbroadbent
Member

Hey @nashby, sorry it's taken so long. I've finally got around to testing and merging your pull request. I've fixed it up and added a few things like error handling for invalid authentication.
Thanks for your work!

@nashby
Member
nashby commented Jun 1, 2012

Hey @ndbroadbent. Awesome, thank you! So are you interested in authentication through github? If so I can prepare a PR.

@ndbroadbent
Member

No problem! And yes, I would be very interested in that! OAuth would be a much better solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment