New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract Fingerprint#generate from ErrorReport #253

Merged
merged 1 commit into from Jun 21, 2013

Conversation

Projects
None yet
5 participants
@boblail
Contributor

boblail commented Sep 20, 2012

This commit is just a refactor to get the fingerprinting concern by itself; but it paves the way for testing the fingerprinting algorithm, evaluating substitute algorithms, and even supporting different algorithms in different scenarios.

@nashby

This comment has been minimized.

Show comment
Hide comment
@nashby

nashby Sep 21, 2012

Member

As for me it doesn't look like a lib code and I think it should be placed in app dir somewhere.

Member

nashby commented Sep 21, 2012

As for me it doesn't look like a lib code and I think it should be placed in app dir somewhere.

@martinciu

View changes

Show outdated Hide outdated lib/fingerprint.rb Outdated
@martinciu

This comment has been minimized.

Show comment
Hide comment
@martinciu

martinciu Sep 21, 2012

Member

@nashby +1 I think it should be in app/models

Member

martinciu commented Sep 21, 2012

@nashby +1 I think it should be in app/models

@boblail

This comment has been minimized.

Show comment
Hide comment
@boblail

boblail Sep 25, 2012

Contributor

Agreed!

I moved fingerprint.rb to app/models and broke generate apart. Good points!

FWIW, I think fingerprint would be better off not including api_key. I'm not sure how likely this scenario is: but suppose a user regenerates the API key for a project. Errbit would start creating all new problems for any repeat notices.

Contributor

boblail commented Sep 25, 2012

Agreed!

I moved fingerprint.rb to app/models and broke generate apart. Good points!

FWIW, I think fingerprint would be better off not including api_key. I'm not sure how likely this scenario is: but suppose a user regenerates the API key for a project. Errbit would start creating all new problems for any repeat notices.

@nashby

View changes

Show outdated Hide outdated spec/models/fingerprint_spec.rb Outdated
@nashby

View changes

Show outdated Hide outdated app/models/fingerprint.rb Outdated
@nashby

This comment has been minimized.

Show comment
Hide comment
@nashby

nashby Oct 29, 2012

Member

@boblail hey, could you please rebase this branch against master? Thanks!

Member

nashby commented Oct 29, 2012

@boblail hey, could you please rebase this branch against master? Thanks!

@boblail

This comment has been minimized.

Show comment
Hide comment
@boblail

boblail Nov 9, 2012

Contributor

@nashby Rebased!

Contributor

boblail commented Nov 9, 2012

@nashby Rebased!

@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara May 9, 2013

Member

I agree with this kind of refactor. This pull request can't be merge. Can you update it to be merged ?

Member

shingara commented May 9, 2013

I agree with this kind of refactor. This pull request can't be merge. Can you update it to be merged ?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 18, 2013

Coverage Status

Changes Unknown when pulling 0d890b1 on concordia-publishing-house:extract-fingerprint into * on errbit:master*.

coveralls commented Jun 18, 2013

Coverage Status

Changes Unknown when pulling 0d890b1 on concordia-publishing-house:extract-fingerprint into * on errbit:master*.

shingara added a commit that referenced this pull request Jun 21, 2013

Merge pull request #253 from concordia-publishing-house/extract-finge…
…rprint

Refactor: extract Fingerprint#generate from ErrorReport

@shingara shingara merged commit eb199be into errbit:master Jun 21, 2013

1 check passed

default The Travis CI build passed
Details
@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara Jun 21, 2013

Member

Thanks

Member

shingara commented Jun 21, 2013

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment