Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Commenting on an error when there is only one user raises an exception #455
As described in issue #452.
It looks like this was introduced in commit: 310b4fc
When the comment author is the only notification_recipient, there are no recipients for the email.
This pull request fixes that by putting the logic of when to send an email notification in the
You're right. That was one of the two reasons I added that method to Comment.
I changed it and I added a few basic tests cases for the comment_notification in mailer_spec. One of the cases checks that the recipients are delegated to Comment#notification_recipients.