New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launch a repairDatabase task on clear_resolved #468

Merged
merged 2 commits into from May 4, 2013

Conversation

Projects
None yet
3 participants
@shingara
Member

shingara commented Apr 30, 2013

The task db:clear_resolved can delete a lot of data. I think it can be good to repairDatabase after to avoid a big database.

see #458

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 38ca535 on shingara:patch-1 into a761933 on errbit:master.

coveralls commented Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 38ca535 on shingara:patch-1 into a761933 on errbit:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 12d9152 on shingara:patch-1 into a761933 on errbit:master.

coveralls commented Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 12d9152 on shingara:patch-1 into a761933 on errbit:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 12d9152 on shingara:patch-1 into a761933 on errbit:master.

coveralls commented Apr 30, 2013

Coverage Status

Coverage decreased (-0.39%) when pulling 12d9152 on shingara:patch-1 into a761933 on errbit:master.

shingara added some commits Apr 30, 2013

launch a repairDatabase task on clear_resolved
The task db:clear_resolved can delete a lot of data. I think it can be good to repairDatabase after to avoid a big database.

see #458
Extract task to clear problem resolved in Interaction class
Extract the task in a class doing the job
Add test on this class
Update rspec and rspec-rails gems
@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara May 4, 2013

Member

I think can be merged now. Any objection ?

Member

shingara commented May 4, 2013

I think can be merged now. Any objection ?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 4, 2013

Coverage Status

Coverage remained the same when pulling c44f9c1 on shingara:patch-1 into 33f2ebc on errbit:master.

coveralls commented May 4, 2013

Coverage Status

Coverage remained the same when pulling c44f9c1 on shingara:patch-1 into 33f2ebc on errbit:master.

@ndbroadbent

This comment has been minimized.

Show comment
Hide comment
@ndbroadbent

ndbroadbent May 4, 2013

Member

Merging, looks good to me!

Member

ndbroadbent commented May 4, 2013

Merging, looks good to me!

ndbroadbent added a commit that referenced this pull request May 4, 2013

Merge pull request #468 from shingara/patch-1
launch a repairDatabase task on clear_resolved

@ndbroadbent ndbroadbent merged commit 0321d15 into errbit:master May 4, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment