New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 422 HTTP status code when invalid API key #475

Merged
merged 5 commits into from May 7, 2013

Conversation

Projects
None yet
2 participants
@shingara
Member

shingara commented May 6, 2013

This Pull request return a 422 HTTP status and explain the error if you push a notice with bad API key.

I refactor a little spec about ErrorReport to use only him and not dependent of app not really usefull.

Code review are welcome

shingara added some commits May 3, 2013

Add some test to try report issue #470
Add some test with notice send with empty backtrace
Add some test directly in the ErrorReport model
Return an 422 HTTP status code in notice submit when API_KEY is not v…
…alid

When a notice is do with an invalid api_key the return is a 404 HTTP
code and no explain about what really happen. Now if you try post a
notice with a bad API_KEY, errbit return a 422 HTTP status code, like
doing by airbrake.

see #472
Extract test from spec/model/app to spec/model/error_report
Some test on spec/model/app are too specific to spec/model/error_report
move to this spec
Extract completly the ErrorReport class
Extract all concern about this call to his own class and move test to
this class
@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara May 6, 2013

Member

Fix issue #472

Member

shingara commented May 6, 2013

Fix issue #472

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 6, 2013

Coverage Status

Coverage increased (+0.26%) when pulling 482518e on shingara:features/issue_472 into 6eb59b4 on errbit:master.

coveralls commented May 6, 2013

Coverage Status

Coverage increased (+0.26%) when pulling 482518e on shingara:features/issue_472 into 6eb59b4 on errbit:master.

shingara added a commit that referenced this pull request May 7, 2013

Merge pull request #475 from shingara/features/issue_472
Return 422 HTTP status code when invalid API key

@shingara shingara merged commit 7f72028 into errbit:master May 7, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment