Return 422 HTTP status code when invalid API key #475

merged 5 commits into from May 7, 2013


None yet

2 participants

shingara commented May 6, 2013

This Pull request return a 422 HTTP status and explain the error if you push a notice with bad API key.

I refactor a little spec about ErrorReport to use only him and not dependent of app not really usefull.

Code review are welcome

shingara added some commits May 3, 2013
@shingara shingara Add some test to try report issue #470
Add some test with notice send with empty backtrace
Add some test directly in the ErrorReport model
@shingara shingara Return an 422 HTTP status code in notice submit when API_KEY is not v…

When a notice is do with an invalid api_key the return is a 404 HTTP
code and no explain about what really happen. Now if you try post a
notice with a bad API_KEY, errbit return a 422 HTTP status code, like
doing by airbrake.

see #472
@shingara shingara Extract test from spec/model/app to spec/model/error_report
Some test on spec/model/app are too specific to spec/model/error_report
move to this spec
@shingara shingara Extract completly the ErrorReport class
Extract all concern about this call to his own class and move test to
this class
@shingara shingara Extract some test from controller/noticess to error_report 482518e
shingara commented May 6, 2013

Fix issue #472


Coverage Status

Coverage increased (+0.26%) when pulling 482518e on shingara:features/issue_472 into 6eb59b4 on errbit:master.

@shingara shingara merged commit 7f72028 into errbit:master May 7, 2013

1 check failed

default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment