New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flowdock configuration option #530

Merged
merged 1 commit into from Aug 17, 2013

Conversation

Projects
None yet
3 participants
@nfedyashev
Contributor

nfedyashev commented Aug 3, 2013

This is missing component to the recent PR.

I thought that another configuration option for flowdock email notification option brings unnecessary complexity.

Probably the simplest way for users to fix default icons in Flowdock notifications is to just add "Errbit" icon on Gravatar for already existing email from ERRBIT_EMAIL_FROM.

What do you think?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 3, 2013

Coverage Status

Coverage increased (+0%) when pulling 9d304ec on nfedyashev:flowdock_improvement into 8800475 on errbit:master.

coveralls commented Aug 3, 2013

Coverage Status

Coverage increased (+0%) when pulling 9d304ec on nfedyashev:flowdock_improvement into 8800475 on errbit:master.

@nfedyashev

This comment has been minimized.

Show comment
Hide comment
@nfedyashev

nfedyashev Aug 4, 2013

Contributor

This PR must fix #511

Contributor

nfedyashev commented Aug 4, 2013

This PR must fix #511

shingara added a commit that referenced this pull request Aug 17, 2013

@shingara shingara merged commit 317f57c into errbit:master Aug 17, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment