New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses https-links for gravatar when using ssl #532

Merged
merged 3 commits into from Aug 8, 2013

Conversation

Projects
None yet
4 participants
@jeroenj
Contributor

jeroenj commented Aug 5, 2013

When using http links over an ssl connection some browsers might give warnings. For example in Safari the https indicator would disappear.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 48367cc on jeroenj:gravatar-ssl into 8800475 on errbit:master.

coveralls commented Aug 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 48367cc on jeroenj:gravatar-ssl into 8800475 on errbit:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 48367cc on jeroenj:gravatar-ssl into 8800475 on errbit:master.

coveralls commented Aug 5, 2013

Coverage Status

Coverage increased (+0%) when pulling 48367cc on jeroenj:gravatar-ssl into 8800475 on errbit:master.

@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara Aug 5, 2013

Member

Thanks but your commit is not 1.8.7 compatible. Can you fix it before I merge it. Otherwise it's OK to me

Member

shingara commented Aug 5, 2013

Thanks but your commit is not 1.8.7 compatible. Can you fix it before I merge it. Otherwise it's OK to me

@jeroenj

This comment has been minimized.

Show comment
Hide comment
@jeroenj

jeroenj Aug 6, 2013

Contributor

Right. I did not think about that. Fixed it. :)

Contributor

jeroenj commented Aug 6, 2013

Right. I did not think about that. Fixed it. :)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 6, 2013

Coverage Status

Coverage increased (+0%) when pulling 6940384 on jeroenj:gravatar-ssl into 8800475 on errbit:master.

coveralls commented Aug 6, 2013

Coverage Status

Coverage increased (+0%) when pulling 6940384 on jeroenj:gravatar-ssl into 8800475 on errbit:master.

@arthurnn

This comment has been minimized.

Show comment
Hide comment
@arthurnn

arthurnn Aug 7, 2013

Member

👍

Member

arthurnn commented Aug 7, 2013

👍

@jeroenj

This comment has been minimized.

Show comment
Hide comment
@jeroenj

jeroenj Aug 8, 2013

Contributor

@shingara Would you mind checking again? It also seems that the Travis succeeded build did not got pushed to github: https://travis-ci.org/errbit/errbit/builds/9890158

Contributor

jeroenj commented Aug 8, 2013

@shingara Would you mind checking again? It also seems that the Travis succeeded build did not got pushed to github: https://travis-ci.org/errbit/errbit/builds/9890158

shingara added a commit that referenced this pull request Aug 8, 2013

Merge pull request #532 from jeroenj/gravatar-ssl
Uses https-links for gravatar when using ssl

@shingara shingara merged commit c9f1742 into errbit:master Aug 8, 2013

1 check was pending

default The Travis CI build is in progress
Details
@shingara

This comment has been minimized.

Show comment
Hide comment
@shingara

shingara Aug 8, 2013

Member

Thanks

Member

shingara commented Aug 8, 2013

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment