GitHub close issue feature #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To test this, you'll need the Gemfile entry for errbit_plugin to point to the git repo, the close-issue branch, or point it to your local copy of that branch. |
Contributor
Author
|
@stevecrozz I'm not sure how to make travis's ruby 2.3 test environment happy regarding this: |
Member
|
For some reason, it has to be '2.3.0' I'm not sure why its inconsistent, but that's what works in the other repos. Btw. I just released v0.6.0 of errbit_plugin which includes your close_issue updates. |
Member
|
@mfrederickson Does that help clear up the build error? Probably we should get this merged and publish a new version before merging the errbit changes. |
Contributor
Author
|
@stevecrozz looks like it worked. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards errbit/errbit#371, but I need help writing the test for the close_issue method...