New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name 'all_plugin_paths' in backend_plugin_manager.py #1233

Closed
cclauss opened this Issue Jul 1, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@cclauss

cclauss commented Jul 1, 2018

Undefined names have the potential to raise NameError at runtime.

flake8 testing of https://github.com/errbotio/errbot on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./errbot/backend_plugin_manager.py:37:91: F821 undefined name 'all_plugin_paths'
        raise PluginNotFoundException(f'Could not find the plugin named {plugin_name} in {all_plugin_paths}.')
                                                                                          ^
1     F821 undefined name 'all_plugin_paths'
1

sijis added a commit to sijis/err that referenced this issue Aug 7, 2018

@wafflebot wafflebot bot assigned sijis Aug 7, 2018

@wafflebot wafflebot bot added the in progress label Aug 7, 2018

@sijis

This comment has been minimized.

Contributor

sijis commented Aug 7, 2018

Put up a PR #1244 to address that. Thanks.

@gbin gbin closed this in #1244 Oct 19, 2018

gbin added a commit that referenced this issue Oct 19, 2018

@wafflebot wafflebot bot removed the in progress label Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment