Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

description seems to be read from bootcmd definition #1405

Merged
merged 1 commit into from Jan 20, 2020

Conversation

@fernand0
Copy link
Contributor

fernand0 commented Jan 11, 2020

Since description seems to be read from @bootcmd definition and this is not easy to see in the documentation (even the examples don't use it, see https://github.com/errbotio/errbot/blob/master/docs/user_guide/flow_development/basics.rst ) maybe it is better to change this code to not produce an error in the command flows list when no description is available.

Since description seems to be read from `@bootcmd` definition and this is not easy to see in the documentation (even the examples don't use it, see https://github.com/errbotio/errbot/blob/master/docs/user_guide/flow_development/basics.rst ) maybe it is better to change this code to not produce an error in the command `flows list` when no description is available.
@sijis

This comment has been minimized.

Copy link
Contributor

sijis commented Jan 20, 2020

Looks good. An example output is

[@sijis ➡ @errbot] >>> !flows list
• poll_setup No description
@sijis sijis merged commit fa60b31 into errbotio:master Jan 20, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sijis

This comment has been minimized.

Copy link
Contributor

sijis commented Jan 20, 2020

Thank you for the fix.

@fernand0 fernand0 deleted the fernand0:patch-7 branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.