Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm version of package does not include custom random function code #18

Closed
timmb opened this issue May 24, 2022 · 1 comment
Closed

Comments

@timmb
Copy link

timmb commented May 24, 2022

Sorry if I'm missing something obvious here. But when pulling the package from npm I find there is no custom rand function for Gaussian.random.

See here

Both npm and Github report version 1.2.0.

But on Github in gaussian.js we have:

  Gaussian.prototype.random = function(num, randFn = null){
    let mean = this.mean;
    let std = this.standardDeviation;
    return Array(num).fill(0).map(() => {
      return generateGaussian(mean,std, randFn)
    })
  };

And on npm we have

  // Generate [num] random samples
  Gaussian.prototype.random = function(num){
    let mean = this.mean;
    let std = this.standardDeviation;
    return Array(num).fill(0).map(() => {
      return generateGaussian(mean,std)
    })
  };
@errcw
Copy link
Owner

errcw commented Jan 18, 2023

I've (finally) pushed version 1.3 to npm that includes this update. (Apologies for the incredible delay here; it's been a busy year and I've had all my open source commitments on pause.)

@errcw errcw closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants