New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to WebExtensions #23

Open
acmiyaguchi opened this Issue May 22, 2017 · 18 comments

Comments

Projects
None yet
8 participants
@acmiyaguchi

acmiyaguchi commented May 22, 2017

This addon is awesome and has been valuable to my mixed dpi setup. However, this addon has been marked as 'legacy' in about:addons on recent builds of Firefox 55 nightly due to the transition to WebExtensions in FF57. In particular, it looks like legacy addons will no longer be supported mid-June on nightly and developer channels.

This MDN comparison between the SDK and WebExtensions seems like a good starting place to look.

@gerv

This comment has been minimized.

Show comment
Hide comment
@gerv

gerv Jun 30, 2017

@ertug: ping? Can you confirm whether or not you plan to update this great add-on?

gerv commented Jun 30, 2017

@ertug: ping? Can you confirm whether or not you plan to update this great add-on?

@ertug

This comment has been minimized.

Show comment
Hide comment
@ertug

ertug Jul 1, 2017

Owner

Thank you! I'd want to but I didn't have the time. I will try to look into it.

Owner

ertug commented Jul 1, 2017

Thank you! I'd want to but I didn't have the time. I will try to look into it.

@ertug

This comment has been minimized.

Show comment
Hide comment
@ertug

ertug Jul 2, 2017

Owner

I had a look at the WebExtensions API and noticed that the API for setting layout.css.devPixelsPerPx is missing. I found a bug about it that also mentions AutoHiDPI:
https://bugzilla.mozilla.org/show_bug.cgi?id=1373607

Owner

ertug commented Jul 2, 2017

I had a look at the WebExtensions API and noticed that the API for setting layout.css.devPixelsPerPx is missing. I found a bug about it that also mentions AutoHiDPI:
https://bugzilla.mozilla.org/show_bug.cgi?id=1373607

@alexbel

This comment has been minimized.

Show comment
Hide comment
@alexbel

alexbel Nov 15, 2017

@ertug looks like layout.css.devPixelsPerPx is back in Firefox 57.0

alexbel commented Nov 15, 2017

@ertug looks like layout.css.devPixelsPerPx is back in Firefox 57.0

@gerv

This comment has been minimized.

Show comment
Hide comment
@gerv

gerv Nov 15, 2017

@alexbel No one ever said the pref was missing. But WebExtensions can't alter arbitrary preferences.

gerv commented Nov 15, 2017

@alexbel No one ever said the pref was missing. But WebExtensions can't alter arbitrary preferences.

@mcanonic

This comment has been minimized.

Show comment
Hide comment
@mcanonic

mcanonic Dec 5, 2017

Without this extension my second monitor is useless. Firefox was the only one app able to auto-adapt to screen with different density. Too bad.

mcanonic commented Dec 5, 2017

Without this extension my second monitor is useless. Firefox was the only one app able to auto-adapt to screen with different density. Too bad.

@kalliste

This comment has been minimized.

Show comment
Hide comment
@kalliste

kalliste Dec 5, 2017

Setting layout.css.devPixelsPerPx to -1 seems to make it do the right thing for me in Firefox 57

kalliste commented Dec 5, 2017

Setting layout.css.devPixelsPerPx to -1 seems to make it do the right thing for me in Firefox 57

@mcanonic

This comment has been minimized.

Show comment
Hide comment
@mcanonic

mcanonic Dec 5, 2017

I tried but the firefox does not change its aspect on my two monitors. Did you set something else? Did you keep this parameter as "string"?

mcanonic commented Dec 5, 2017

I tried but the firefox does not change its aspect on my two monitors. Did you set something else? Did you keep this parameter as "string"?

@gerv

This comment has been minimized.

Show comment
Hide comment
@gerv

gerv Dec 6, 2017

What "-1" seems to do is to cause Firefox to calculate a good value for this pref every time it restarts. I don't think it's possible to get Firefox to render at a different perpx value on two monitors simultaneously.

gerv commented Dec 6, 2017

What "-1" seems to do is to cause Firefox to calculate a good value for this pref every time it restarts. I don't think it's possible to get Firefox to render at a different perpx value on two monitors simultaneously.

@kalliste

This comment has been minimized.

Show comment
Hide comment
@kalliste

kalliste Dec 7, 2017

On Firefox 57 on Mac it is readjusting for me each time I move between the retina display and the external monitor, without restarting the browser. This was working with the value set as -1 and is now still working with the value reset to default and showing as -1.0

kalliste commented Dec 7, 2017

On Firefox 57 on Mac it is readjusting for me each time I move between the retina display and the external monitor, without restarting the browser. This was working with the value set as -1 and is now still working with the value reset to default and showing as -1.0

@mcanonic

This comment has been minimized.

Show comment
Hide comment
@mcanonic

mcanonic Dec 7, 2017

Thanks, it seems that this does not work on Linux. Has anyone tried this on Linux?

mcanonic commented Dec 7, 2017

Thanks, it seems that this does not work on Linux. Has anyone tried this on Linux?

@kalliste

This comment has been minimized.

Show comment
Hide comment
@kalliste

kalliste Dec 7, 2017

It looks like this may work if you have Wayland and install a (still experimental) Wayland build of Firefox. You should be using Wayland already if you happen to be on a fresh install of Ubuntu 17.10 and you can install Wayland Firefox using Flatpak https://firefox-flatpak.mojefedora.cz/

kalliste commented Dec 7, 2017

It looks like this may work if you have Wayland and install a (still experimental) Wayland build of Firefox. You should be using Wayland already if you happen to be on a fresh install of Ubuntu 17.10 and you can install Wayland Firefox using Flatpak https://firefox-flatpak.mojefedora.cz/

@grahamperrin

This comment has been minimized.

Show comment
Hide comment
@grahamperrin

grahamperrin commented Feb 10, 2018

… WebExtensions can't alter arbitrary preferences.

Mozilla bug 1363856 - [tracker] Implement WebExtensions API to give access to specific preferences

@gigitux

This comment has been minimized.

Show comment
Hide comment
@gigitux

gigitux May 10, 2018

Have you found a workaround to run firefox on monitor with different dpi?

gigitux commented May 10, 2018

Have you found a workaround to run firefox on monitor with different dpi?

@mcanonic

This comment has been minimized.

Show comment
Hide comment
@mcanonic

mcanonic May 17, 2018

NO, I have bought a new monitor 4k.
In the meanwhile I used firefox in just one (of the two) monitor and I have set the layout.css.depixelperpx field in about:config to 3 (or 4). You can also play with the firefox zoom. These solutions work only if you decide ONE SINGLE monitor to be dedicated to firefox. I'm still wondering why firefox did not implement an "auto-zoom" feature.

mcanonic commented May 17, 2018

NO, I have bought a new monitor 4k.
In the meanwhile I used firefox in just one (of the two) monitor and I have set the layout.css.depixelperpx field in about:config to 3 (or 4). You can also play with the firefox zoom. These solutions work only if you decide ONE SINGLE monitor to be dedicated to firefox. I'm still wondering why firefox did not implement an "auto-zoom" feature.

@gigitux

This comment has been minimized.

Show comment
Hide comment
@gigitux

gigitux May 17, 2018

Thanks for your answer! :D
"In the meanwhile I used firefox in just one (of the two) monitor"
Same here!

gigitux commented May 17, 2018

Thanks for your answer! :D
"In the meanwhile I used firefox in just one (of the two) monitor"
Same here!

@kalliste

This comment has been minimized.

Show comment
Hide comment
@kalliste

kalliste May 19, 2018

@gigitux @mcanonic when I set layout.css.devPixelsPerPx to -1 it seems to do the right thing for me. What is yours set to?

kalliste commented May 19, 2018

@gigitux @mcanonic when I set layout.css.devPixelsPerPx to -1 it seems to do the right thing for me. What is yours set to?

@mcanonic

This comment has been minimized.

Show comment
Hide comment
@mcanonic

mcanonic May 21, 2018

My first set was 2, then I set it to 1 for my external monitor. The "-1" does not scale: when I move the firefox wondow from one monitor to the other, I get bad results.

mcanonic commented May 21, 2018

My first set was 2, then I set it to 1 for my external monitor. The "-1" does not scale: when I move the firefox wondow from one monitor to the other, I get bad results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment