Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 7.4 RC2 incompatibility #135

Merged
merged 2 commits into from Dec 21, 2019
Merged

Fix PHP 7.4 RC2 incompatibility #135

merged 2 commits into from Dec 21, 2019

Conversation

storeman
Copy link
Contributor

@storeman storeman commented Sep 23, 2019

Fixes #134

@GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Dec 20, 2019

@erusev could you please merge this important fix for PHP 7.4 compatibility. The library is totally unusable on PHP 7.4 otherwise.

@erusev erusev merged commit a0ce447 into erusev:master Dec 21, 2019
1 check failed
@erusev
Copy link
Owner

@erusev erusev commented Dec 21, 2019

Done.

@aidantwoods can we create a patch release for this change?

@GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Dec 21, 2019

Better to merge in the travis stuff and fix the tests first.

@GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Dec 21, 2019

brainexe added a commit to brainexe/markdown2html that referenced this issue Feb 6, 2020
PHP Notice:  Trying to access array offset on value of type null in vendor/erusev/parsedown-extra/ParsedownExtra.php on line 241

fixed in erusev/parsedown-extra#135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants