Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 7.4 RC2 incompatibility #135

Merged
merged 2 commits into from Dec 21, 2019
Merged

Fix PHP 7.4 RC2 incompatibility #135

merged 2 commits into from Dec 21, 2019

Conversation

@storeman
Copy link
Contributor

storeman commented Sep 23, 2019

Fixes #134

storeman and others added 2 commits May 28, 2015
@GrahamCampbell

This comment has been minimized.

Copy link
Contributor

GrahamCampbell commented Dec 20, 2019

@erusev could you please merge this important fix for PHP 7.4 compatibility. The library is totally unusable on PHP 7.4 otherwise.

@erusev erusev merged commit a0ce447 into erusev:master Dec 21, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@erusev

This comment has been minimized.

Copy link
Owner

erusev commented Dec 21, 2019

Done.

@aidantwoods can we create a patch release for this change?

@GrahamCampbell

This comment has been minimized.

Copy link
Contributor

GrahamCampbell commented Dec 21, 2019

Better to merge in the travis stuff and fix the tests first.

@GrahamCampbell

This comment has been minimized.

Copy link
Contributor

GrahamCampbell commented Dec 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.