Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for string module & chunk ids #195

Closed
Whoaa512 opened this issue Dec 13, 2019 · 2 comments · Fixed by #205 or #214
Closed

Support for string module & chunk ids #195

Whoaa512 opened this issue Dec 13, 2019 · 2 comments · Fixed by #205 or #214
Assignees
Labels
bug
Projects
Milestone

Comments

@Whoaa512
Copy link
Contributor

@Whoaa512 Whoaa512 commented Dec 13, 2019

I'm trying to load up some stats files created using the webpack.NamedChunksPlugin by creating my own hash.

This breaks with the following error:

Expected number, got "fdef"
  in array at index 0
  at field 'chunks'
  in array at index 1
  at field 'assets'

How can I get this working?

@erykpiast

This comment has been minimized.

Copy link
Owner

@erykpiast erykpiast commented Dec 22, 2019

Hi @Whoaa512, thank you for reporting the bug! I suppose it's a mistake in typings I've created for Webpack's stats file. If I took a blind shot, I'd say it's an issue here. I don't even use this field, I just want to have a strict type for everything in the structure, but bs-json parser doesn't forgive.

I'll change the type to string, numbers should be coerced correctly anyway. Could you upload here stat files you're working with, so I can test it before deploying?

@erykpiast erykpiast self-assigned this Dec 22, 2019
@erykpiast erykpiast added the bug label Dec 22, 2019
@erykpiast erykpiast added this to To do in default via automation Dec 22, 2019
@erykpiast erykpiast added this to the v1 milestone Dec 22, 2019
default automation moved this from To do to Done Dec 22, 2019
@erykpiast

This comment has been minimized.

Copy link
Owner

@erykpiast erykpiast commented Dec 22, 2019

Alright, I reproduced the issue and confirmed that chunks list type was a problem. The fixed version is deployed. @Whoaa512 could you check if everything works for you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
default
  
Done
2 participants
You can’t perform that action at this time.