Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR error will result in unhandled promise rejection and timeout #12

Closed
kamsar opened this issue Oct 15, 2019 · 0 comments
Labels
bug

Comments

@kamsar
Copy link

@kamsar kamsar commented Oct 15, 2019

The server.js:

callback(null, { html: indexHtml });

invokes the SSR callback function as long as everything goes well. However if there is an error executing the SSR that results in an exception in the server.js promise body, there is no .catch on the promise body and thus the callback is never invoked in the case of an error occurring.

A catch function should be added to the SSR promise that invokes the error callback, such that errors bubble back up to .NET/ssr-proxy. For example: https://github.com/Sitecore/jss/blob/bf538926ba52b361e0afe2955416229d9a6e5c7a/samples/react/server/server.js#L124

@erzr erzr added the bug label Oct 20, 2019
@erzr erzr closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.